Update performance.md - Remove old curl commands #8761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating old curl examples to current standard across the rest of the documentation. Signed-off-by: Landon Lengyel <[email protected]>
landon-lengyel
requested review from
kolchfa-aws,
Naarcha-AWS,
vagimeli,
AMoo-Miki,
natebower,
dlvenable and
epugh
as code owners
|
Thank you for submitting your PR. The PR states are In progress (or Draft) -> Tech review -> Doc review -> Editorial review -> Merged. Before you submit your PR for doc review, make sure the content is technically accurate. If you need help finding a tech reviewer, tag a maintainer. When you're ready for doc review, tag the assignee of this PR. The doc reviewer may push edits to the PR directly or leave comments and editorial suggestions for you to address (let us know in a comment if you have a preference). The doc reviewer will arrange for an editorial review. |
kolchfa-aws
reviewed
Nov 15, 2024
There was a problem hiding this comment.
Thank you, @landon-lengyel! A couple of suggestions. The copy-curl include adds both copy and copy as curl buttons to the request.
Signed-off-by: kolchfa-aws <[email protected]>
kolchfa-aws
approved these changes
Nov 21, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Nov 21, 2024
* Update performance.md Updating old curl examples to current standard across the rest of the documentation. Signed-off-by: Landon Lengyel <[email protected]> * Apply suggestions from code review Signed-off-by: kolchfa-aws <[email protected]> --------- Signed-off-by: Landon Lengyel <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> Co-authored-by: kolchfa-aws <[email protected]> (cherry picked from commit f39ba2f) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
epugh
pushed a commit
to o19s/documentation-website
that referenced
this pull request
Nov 23, 2024
…8761) * Update performance.md Updating old curl examples to current standard across the rest of the documentation. Signed-off-by: Landon Lengyel <[email protected]> * Apply suggestions from code review Signed-off-by: kolchfa-aws <[email protected]> --------- Signed-off-by: Landon Lengyel <[email protected]> Signed-off-by: kolchfa-aws <[email protected]> Co-authored-by: kolchfa-aws <[email protected]> Signed-off-by: Eric Pugh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This document uses curl for all of it's examples, while the rest of the documentation has shifted towards the "Dev Console" style of example.
This PR updates the document updates that.
Issues Resolved
N/A
Version
all
Frontend features
N/A
Checklist
For more information on following Developer Certificate of Origin and signing off your commits, please check here.